helium/ui/centered-address-bar: add centered address bar#871
helium/ui/centered-address-bar: add centered address bar#871jamdaniels wants to merge 1 commit intoimputnet:mainfrom
Conversation
jamdaniels
force-pushed
the
wide-address-bar-toggle
branch
from
9cd6ab7 to
dd85fb2
Compare
jamdaniels
changed the title
I hope this fits better, I also tried to match the naming patterns. 
helium-pr-1.mp4 |
|
When will this be merged? |
|
@wukko do you want me to resolve the conflicts now or should I wait for further changes until this is 'in line' to be merged or do you guys have other plans? Will you let me know or should I just keep resolving the conflicts? |
|
Is it possible to move the URL also to the center of address bar like in Duckduckgo? |
|
I think this would be great for vertical tabs since the address bar takes the whole width and it gets very hard to grab the window and move it around on Windows or macOS... More free space around the address bar would be nice! |
fanckush
left a comment
fanckush
left a comment
There was a problem hiding this comment.
can't wait for this to get merged! moving the window now is very difficult, there is virtually no place to drag from
| + | ||
| + gfx::Rect bounds = location_bar_->bounds(); | ||
| + const int total_margin = static_cast<int>(toolbar_width * margin_pct); | ||
| + constexpr int kMaxLocationBarWidth = 900; |
There was a problem hiding this comment.
what do you think about making this hardcoded value parametrized? this is one feature brave doesn't have and would be really cool to be able to set the max width dynamically from settings
|
|
||
| BooleanPrefMember show_menu_button_; | ||
|
|
||
| + BooleanPrefMember location_bar_is_centered_; |
There was a problem hiding this comment.
| + BooleanPrefMember location_bar_is_centered_; | |
| + BooleanPrefMember is_location_bar_centered_; |
just a thought, feel free to ignore, but since it's a boolean this reads more intuitively
|
@jamdaniels maybe if you request re-review at the top right, you might get another review from the maintainers |
6 participants
For your pull request to not get closed without review, please confirm that:
(an approved feature request, or confirmed bug).
otherwise I have marked my PR as draft.
organization if I lied by checking any of these checkboxes.
Tested on (check one or more):
This PR adds a setting to toggle between the current used, full width address bar and a more narrow, centered, responsive address bar with a fixed max width of 900px. Currently, the full-width address bar is disabled by default. These additions are skipped if the CAT feature is active. I've researched how the centered, responsive address bar is implemented in Brave, which already does this and this solution is inspired by it.
Closes #104
Pictures:
Video showcase:
helium-wide-address-bar.mp4
I do want to say that I used AI to implement this, but I didn't "vibe code" it. I did a lot of back and forth with multiple frontier models, discussed how to implement this feature properly while following best practices and look out for possible concerns and thoroughly tested all scenarios locally. I just want to help out and I would love if this feature gets added. If the full-width address bar should stay the default, let me know and I'm happy to change that and anything else necessary.