Proportion of new users activated and top edited content pages for the selected time range #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Nivas10798
reviewed
Jul 26, 2025
notebooks/notebook-mohan.ipynb
Outdated
| @@ -0,0 +1,799 @@ | |||
| { | |||
There was a problem hiding this comment.
notebooks/notebook-mohan.ipynb
Outdated
| @@ -0,0 +1,799 @@ | |||
| { | |||
There was a problem hiding this comment.
Some larger thoughts on this code block
- The overall code is written using AI tools.
- Only two wikis are taken into account while three were mentioned as part of this exercise
- The graph is not depicting the values of each bar
- Do follow the order when plotting on X and Y axis (alphabetical, ascending, etc)
Reply via ReviewNB
notebooks/notebook-mohan.ipynb
Outdated
| @@ -0,0 +1,799 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #49. wikis = ['tewiki', 'mlwiki']
Please analyse for three wikis hiwiki, tewiki, mlwiki
Reply via ReviewNB
notebooks/notebook-mohan.ipynb
Outdated
| @@ -0,0 +1,799 @@ | |||
| { | |||
There was a problem hiding this comment.
- Missing comments
- Reordering the date will not be of use in this case as we are looking from the edit count
Reply via ReviewNB
notebooks/notebook-mohan.ipynb
Outdated
| @@ -0,0 +1,799 @@ | |||
| { | |||
There was a problem hiding this comment.
notebooks/notebook-mohan.ipynb
Outdated
| @@ -0,0 +1,799 @@ | |||
| { | |||
There was a problem hiding this comment.
- The code is AI tool generated
- Values in page_title column should be converted to necessary format when using in a table
- The page_url links are broken as the page title conversion is not done
Reply via ReviewNB
notebooks/notebook-mohan.ipynb
Outdated
| @@ -0,0 +1,799 @@ | |||
| { | |||
There was a problem hiding this comment.
notebooks/notebook-mohan.ipynb
Outdated
| @@ -0,0 +1,799 @@ | |||
| { | |||
There was a problem hiding this comment.
- The code is generated using AI tool
- The consistency in the plots is missing (scale of the plot)
- The generated visualisation is a bar graph and not a histogram plot
- Good to write the X values in more readable format (visualeditor -> VisualEditor or Visual Editor)
Reply via ReviewNB
Mohan1503
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.