Entropy stable DG and flux-differencing#214
Closed
thomasgibson wants to merge 25 commits intomainfrom
Closed
Conversation
Collaborator
thomasgibson
commented
Jan 14, 2022
thomasgibson
commented
- Requires the lazy array context provided in: [Lazy evaluation] Pytato Array Context with transformations meshmode#248
- Requires the features of this loopy fork: https://github.com/kaushikcfd/loopy/tree/pytato-array-context-transforms
inducer
reviewed
Jan 25, 2022
inducer
reviewed
Jan 25, 2022
|
|
||
| faces = faces_for_shape(base_grp.shape) | ||
| nfaces = len(faces) | ||
| # NOTE: assumes same quadrature rule on all faces |
inducer
reviewed
Jan 26, 2022
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
More comments from (the second half) of our meeting
grudge/models/euler.py
Outdated
Comment on lines
575
to
576
| _reshape((1, -1), qtilde_allquad), | ||
| _reshape((-1, 1), qtilde_allquad), |
grudge/models/euler.py
Outdated
Comment on lines
575
to
576
| _reshape((1, -1), qtilde_allquad), | ||
| _reshape((-1, 1), qtilde_allquad), |
Owner
There was a problem hiding this comment.
(i.e. there's some benefit to doing this operator-ly)
thomasgibson
force-pushed
the
flux-differencing
branch
from
140bef0 to
7de0c41
Compare
thomasgibson
force-pushed
the
flux-differencing
branch
from
7de0c41 to
48cfae2
Compare
inducer
reviewed
Jan 26, 2022
Comment on lines
479
to
481
| mass_flux = rho_mean * u_avg | ||
| momentum_flux = np.outer(mass_flux, u_avg) + np.eye(dim) * p_mean | ||
| energy_flux = ( |
inducer
reviewed
Jan 26, 2022
Comment on lines
+131
to
+138
| q_mats = [p_mat.T @ (weights * vdm_q.T @ vdm_q) @ diff_mat @ p_mat | ||
| for diff_mat in diff_matrices(vgrp)] | ||
| e_mat = vf_mat @ p_mat | ||
| qtilde_mats = 0.5 * np.asarray( | ||
| [np.block([[q_mats[d] - q_mats[d].T, e_mat.T @ b_mats[d]], | ||
| [-b_mats[d] @ e_mat, b_mats[d]]]) | ||
| for d in range(dcoll.dim)] | ||
| ) |
Owner
There was a problem hiding this comment.
Not loving that this repeats code from the hybridized op implementation.
thomasgibson
force-pushed
the
flux-differencing
branch
from
9c40c3c to
f9142f4
Compare
thomasgibson
force-pushed
the
flux-differencing
branch
from
927da01 to
09d2027
Compare
thomasgibson
force-pushed
the
flux-differencing
branch
from
09d2027 to
7de9f81
Compare
2 tasks
Owner
|
See #306 for an initial attempt at updating this for modern-day grudge. |
inducer
added a commit
that referenced
this pull request
Apr 14, 2023
This is #214 squashed and rebased. Co-authored-by: Andreas Kloeckner <inform@tiker.net>
inducer
added a commit
that referenced
this pull request
Apr 14, 2023
This is #214 squashed and rebased. Co-authored-by: Andreas Kloeckner <inform@tiker.net>
Owner
|
Closing in favor of #306. |
inducer
added a commit
that referenced
this pull request
Jun 23, 2023
This is #214 squashed and rebased. Co-authored-by: Andreas Kloeckner <inform@tiker.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.