Skip to content

Conversation

yuzhichang
Copy link
Member

@yuzhichang yuzhichang commented Sep 28, 2025

Fix highlight with infinity
Fix on OpenSUSE Tumbleweed

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

@yuzhichang yuzhichang requested a review from Copilot September 28, 2025 09:50
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ♾️infinity Pull requests that‘s involved with infinity(DB) 🐞 bug Something isn't working, pull request that fix bug. labels Sep 28, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes highlighting functionality with the Infinity database on OpenSUSE Tumbleweed by enhancing text highlighting logic to handle both English and non-English content, along with several code style improvements.

  • Enhanced highlight functionality to properly detect and handle existing highlighted text
  • Added language-specific highlighting logic for English vs non-English text
  • Updated PyICU dependency version and added OpenSUSE installation instructions

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
rag/utils/infinity_conn.py Enhanced highlighting logic, added language detection, code style improvements
pyproject.toml Updated PyICU dependency to version 2.15.3
download_deps.py Removed commented argparse dependency
deepdoc/parser/pdf_parser.py Added math import
README.md Added OpenSUSE installation instructions and improved formatting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yuzhichang yuzhichang force-pushed the fix_infinity_highlight branch from 4339c6d to b2bafe2 Compare September 28, 2025 09:58
@yuzhichang yuzhichang added the ci Continue Integration label Sep 28, 2025
@yuzhichang yuzhichang force-pushed the fix_infinity_highlight branch from b2bafe2 to 15e4448 Compare September 30, 2025 10:30
@yingfeng yingfeng merged commit 518a006 into infiniflow:main Sep 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working, pull request that fix bug. ci Continue Integration ♾️infinity Pull requests that‘s involved with infinity(DB) size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants