Skip to content

Conversation

@git-nandor
Copy link
Contributor

INSTUI-4876
INSTUI-4877

Summary

Migrated List and InlineList component from the old theming system.

Test plan

On the documentation page, verify that everything displays and works correctly.

Co-Authored-By: 🤖 Claude

@git-nandor git-nandor self-assigned this Dec 15, 2025
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

PR Preview Action v1.8.0
Preview removed because the pull request was closed.
2026-01-16 15:28 UTC

@git-nandor git-nandor force-pushed the INSTUI-4876_list_rework branch from 19734f7 to 16b5427 Compare December 15, 2025 16:54
@git-nandor git-nandor marked this pull request as ready for review December 15, 2025 16:55
@git-nandor git-nandor force-pushed the INSTUI-4876_list_rework branch from 16b5427 to dc40cb4 Compare December 16, 2025 08:39
Copy link
Collaborator

@adamlobler adamlobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List items aren’t getting the proper tokens for some reason. The text color should be white in the dark theme, and the font family should change as well. Maybe they’re not using the inlineListItem / listItem CSS values. 

Image

@git-nandor git-nandor force-pushed the INSTUI-4876_list_rework branch from dc40cb4 to d8de7ed Compare December 17, 2025 09:16
@git-nandor
Copy link
Contributor Author

List items aren’t getting the proper tokens for some reason. The text color should be white in the dark theme, and the font family should change as well. Maybe they’re not using the inlineListItem / listItem CSS values. 

Solved. The tokens now receive the correct values.

@git-nandor git-nandor force-pushed the INSTUI-4876_list_rework branch 2 times, most recently from 0be30e8 to 9abad94 Compare December 19, 2025 08:42
@git-nandor git-nandor requested a review from ToMESSKa December 19, 2025 08:42
@git-nandor git-nandor force-pushed the INSTUI-4876_list_rework branch from 9abad94 to e13556a Compare December 19, 2025 10:19
@git-nandor git-nandor force-pushed the INSTUI-4876_list_rework branch 2 times, most recently from e73de0e to eee41e7 Compare January 6, 2026 13:09
Copy link
Contributor

@ToMESSKa ToMESSKa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I cannot see the solid and dashed delimiters in the preview build like in v11

@git-nandor git-nandor force-pushed the INSTUI-4876_list_rework branch from eee41e7 to f6d173e Compare January 10, 2026 12:51
@git-nandor
Copy link
Contributor Author

I cannot see the solid and dashed delimiters in the preview build like in v11

Thanks, good catch! I fixed it, now it handles the TokenBorderValue type.

@git-nandor git-nandor requested a review from ToMESSKa January 10, 2026 12:56
@git-nandor git-nandor merged commit 1efef19 into v12 Jan 16, 2026
8 of 9 checks passed
@git-nandor git-nandor deleted the INSTUI-4876_list_rework branch January 16, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants