Skip to content

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Dec 17, 2025

INSTUI-4805

ISSUE:

  • RangeInput needs to be migarted to the new theming system

TEST PLAN:

@ToMESSKa ToMESSKa changed the title Inst UI 4805 range input rework [v12] feat(ui-form-field): rework RangeInput Dec 17, 2025
@ToMESSKa ToMESSKa self-assigned this Dec 17, 2025
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-01-21 10:45 UTC

@ToMESSKa ToMESSKa changed the title [v12] feat(ui-form-field): rework RangeInput [v12] feat(ui-range-input): rework RangeInput Dec 17, 2025
@ToMESSKa ToMESSKa force-pushed the INSTUI-4805-range-input-rework branch from 5b5c44f to de126e9 Compare December 17, 2025 15:50
Copy link
Collaborator

@adamlobler adamlobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the original component the padding around the value tooltip was only a horizontal padding, now its a full padding, we should revert this to the original one:

Image

Other than that, it looks okay. There’s just one more small thing, but we should update the tokens as well since we don’t have a proper solution right now... The focus ring isn’t visible in the dark theme, and we don’t currently have a focus color that fits here. I’ll update the tokens and get back to you with a solution:

Image

@ToMESSKa ToMESSKa force-pushed the INSTUI-4805-range-input-rework branch from de126e9 to 21f414b Compare December 18, 2025 14:44
@ToMESSKa
Copy link
Contributor Author

On the original component the padding around the value tooltip was only a horizontal padding, now its a full padding, we should revert this to the original one:

Image Other than that, it looks okay. There’s just one more small thing, but we should update the tokens as well since we don’t have a proper solution right now... The focus ring isn’t visible in the dark theme, and we don’t currently have a focus color that fits here. I’ll update the tokens and get back to you with a solution: Image

@adamlobler Now the padding token only applies the horizontal padding, I set the vertical padding to 0. Also the focus ring should be okay now, can you check it please?

@ToMESSKa ToMESSKa requested a review from adamlobler December 18, 2025 14:58
Copy link
Collaborator

@adamlobler adamlobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paddings and the focusBorder looks okay, thanks for the modification👌 We just need to make some smaller modifications on the token values but its not on your side.

@ToMESSKa ToMESSKa force-pushed the INSTUI-4805-range-input-rework branch from 21f414b to 5ef95fd Compare December 23, 2025 11:05
@ToMESSKa ToMESSKa requested review from balzss and removed request for joyenjoyer December 23, 2025 11:06
balzss
balzss previously requested changes Jan 7, 2026
@ToMESSKa ToMESSKa force-pushed the INSTUI-4805-range-input-rework branch from 5ef95fd to b559009 Compare January 13, 2026 13:19
@ToMESSKa ToMESSKa requested a review from balzss January 13, 2026 13:59
@balzss balzss requested review from joyenjoyer and removed request for balzss January 15, 2026 00:52
@ToMESSKa ToMESSKa requested a review from balzss January 21, 2026 09:00
@ToMESSKa ToMESSKa force-pushed the INSTUI-4805-range-input-rework branch from b559009 to 8786696 Compare January 21, 2026 10:29
@ToMESSKa ToMESSKa removed the request for review from balzss January 21, 2026 10:42
@ToMESSKa ToMESSKa dismissed balzss’s stale review January 21, 2026 10:44

joyenjoyer finished the review instead of balzss

@ToMESSKa ToMESSKa merged commit 8a335bf into v12 Jan 21, 2026
8 of 9 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4805-range-input-rework branch January 21, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants