-
Notifications
You must be signed in to change notification settings - Fork 107
[v12] feat(ui-tray): Tray rework #2348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
d95aebd to
2b91fd6
Compare
packages/ui-tray/src/Tray/styles.ts
Outdated
| boxShadow: [ | ||
| componentTheme.boxShadow['0'], | ||
| componentTheme.boxShadow['1'] | ||
| ] | ||
| .map((s) => `${s.x} ${s.y} ${s.blur} ${s.spread} ${s.color}`) | ||
| .join(', ') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for box shadows, this util should be used https://github.com/instructure/instructure-ui/blob/v12/packages/ui-themes/src/utils/boxShadowObjectToString.ts
see this post: https://instructure.slack.com/archives/G01DAT0KGKE/p1765463895944019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I modified
2b91fd6 to
31c61f2
Compare
adamlobler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
INSTUI-4817
Summary
Migrated Tray component from the old theming system.
Test plan
On the documentation page, verify that everything displays and works correctly.
Co-Authored-By: 🤖 Claude