Skip to content

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Jan 13, 2026

INSTUI-4790

ISSUE:

  • Calendar, DateInput and DateInput2 need to be migarted to the new theming system

TEST PLAN:

@ToMESSKa ToMESSKa self-assigned this Jan 13, 2026
Comment on lines +34 to 35
<Text>Input Value: </Text><code>{inputValue}</code>
<br />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed these to make the text visible in the dark theme

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2354/

Built to branch gh-pages at 2026-01-22 14:05 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ToMESSKa ToMESSKa requested review from HerrTopi and matyasf January 13, 2026 11:22
@ToMESSKa ToMESSKa changed the title feat(ui-date-input,ui-calendar): rework Calendar and DateInput [v12] feat(ui-date-input,ui-calendar): rework Calendar and DateInput Jan 13, 2026
@ToMESSKa ToMESSKa requested a review from adamlobler January 13, 2026 14:20
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!


In the examples above you can see that the `onChange` callback also return a UTC date string. This means it is timezone adjusted. If the timezone is not set via the `timezone` prop, it is calculated/assumed from the user's machine. So if a user chooses September 10th 2024 with the timezone 'Europe/Budapest', the `onChange` function will return `2024-09-09T22:00:00.000Z` because Budapest is two hours ahead of UTC (summertime).

### With year picker
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see this example has the double focus bug. My PR #2347 that should fix this is merged, lets not forget to check this

Image

Copy link
Collaborator

@adamlobler adamlobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The input and the button both can have focus at the same time:
Image

@ToMESSKa ToMESSKa force-pushed the INSTUI-4790-date-input-and-calendar-rework branch from b8cca50 to 074138e Compare January 15, 2026 13:09
@ToMESSKa
Copy link
Contributor Author

The input and the button both can have focus at the same time: Image

@adamlobler This must be fixed now (I rebased it), please check.

@ToMESSKa ToMESSKa requested a review from adamlobler January 15, 2026 13:22
Copy link
Collaborator

@adamlobler adamlobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 🙌

@ToMESSKa ToMESSKa force-pushed the INSTUI-4790-date-input-and-calendar-rework branch from 074138e to 53bbc4c Compare January 22, 2026 14:01
@ToMESSKa ToMESSKa merged commit f7cb32e into v12 Jan 22, 2026
7 of 8 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4790-date-input-and-calendar-rework branch January 22, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants