fix: destroy the resource on drift

[yordis]

closes #749

Based on the request from @jcudit #749 (comment) related to #749 (comment)

[github-actions]

👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

[yordis]

hopefully will figure out how to test this locally one day 😢

[kfcampbell]

@yordis have you had a peek at our CONTRIBUTING.md yet? There's some environment configuration you need but testing changes locally is very doable.

[yordis]

@kfcampbell definitely helped a ton, my breakpoint is being hit now. Now trying to figure out how we suppose to setup the test case for it!

[yordis]

I am trying to figure out what function would allow me to check if a new id was assigned to the resource ... any feedback welcome

[yordis]

The thing is working! Just the testing environment is tricky! I am unsure how to create a scenario where the external resource change and whatnot ... 😢

2023-08-10_19-27-09.mp4

[kfcampbell]

@yordis can you build a version of the provider locally and use it to manually test?

[yordis]

@kfcampbell good idea!

[yordis]

Hey I gave it a try to test it by building the local plugin, but I couldn't figure out how to make it work:

I did the following:

cat ~/.terraformrc         
provider_installation {
  dev_overrides {
    "integrations/github" = "/Users/ubi/Developer/github.com/integrations/terraform-provider-github/bin/"
  }

  direct {}
}

No luck, I tested manually as I showed before, so maybe try on your end if you do not mind.

[kfcampbell]

@yordis can you try following the instructions here to build the provider locally? You should be using a dev.tfrc file in order to specify the override.

[yordis]

I tried that guideline multiple times, and it didn't work.

As shown in the video, I tested by running the code in the test environment. I would appreciate it if someone took the lead in helping to do an integration test out of the generated binary.

[github-actions]

👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

[yordis]

keep

[MagnusHJensen]

Hi @yordis

We're running into the same problem just with regular action secrets.
I would like to offer my help in getting this fixed.

I can see your approach is to add a new destroy_on_drift property, but could we not just respect the already available ignore_changes array? And then check for either plaintext_value or encrypted_value appearing in that array, and not destroy it on drift, instead of introducing a new variable/config option? LMK what you think.

[nbali]

Why wasn't this merged?

[github-actions]

👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

[nbali]

this is funny, because we can't