Skip to content

Fix required workflows for organization rulesets #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
o-sama wants to merge 1 commit into from
Closed

Fix required workflows for organization rulesets #2253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions github/respository_rules_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,29 @@ func flattenRules(rules []*github.RepositoryRule, org bool) []interface{} {
rule["required_check"] = requiredStatusChecksSlice
rule["strict_required_status_checks_policy"] = params.StrictRequiredStatusChecksPolicy
rulesMap[v.Type] = []map[string]interface{}{rule}

case "workflows":
Copy link
Contributor

@kfcampbell kfcampbell Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How might this behavior be unit tested?

var params github.RequiredWorkflowsRuleParameters
log.Printf("[DEBUG] osama test: %v", v.Parameters)
Copy link
Contributor

@kfcampbell kfcampbell Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this before we merge?


err := json.Unmarshal(*v.Parameters, &params)
if err != nil {
log.Printf("[INFO] Unexpected error unmarshalling rule %s with parameters: %v",
v.Type, v.Parameters)
}

requiredWorkflowsSlice := make([]map[string]interface{}, 0)
for _, workflow := range params.RequiredWorkflows {
requiredWorkflowsSlice = append(requiredWorkflowsSlice, map[string]interface{}{
"repository_id": workflow.RepositoryID,
"ref": *workflow.Ref,
"path": workflow.Path,
})
}

rule := make(map[string]interface{})
rule["required_workflow"] = requiredWorkflowsSlice
rulesMap[v.Type] = []map[string]interface{}{rule}
Copy link
Contributor

@ihor-hrytskiv ihor-hrytskiv Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rulesMap[v.Type] = []map[string]interface{}{rule}
rulesMap["required_workflows"] = []map[string]interface{}{rule}

you cannot use "v.Type" because it is named required_workflows in the scheme, not workflows. Look in my PR, I also add "do_not_enforce_on_create" to the scheme

}
}

Expand Down