Skip to content

Update security_and_analysis settings only when there are changes #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Update security_and_analysis settings only when there are changes #2397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a409414
Update security_and_analysis settings only when there are changes
Sep 20, 2024
e3a53f1
Merge branch 'main' into update-repo-security-analysis-separately
kfcampbell Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions github/resource_github_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,11 @@ func resourceGithubRepositoryUpdate(d *schema.ResourceData, meta interface{}) er
// handle visibility updates separately from other fields
repoReq.Visibility = nil

if !d.HasChange("security_and_analysis") {
repoReq.SecurityAndAnalysis = nil
log.Print("[DEBUG] No security_and_analysis update required. Removing this field from the payload.")
}

// The documentation for `default_branch` states: "This can only be set
// after a repository has already been created". However, for backwards
// compatibility we need to allow terraform configurations that set
Expand Down