fix: Fixed branch protection v3 status checks churn #2502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
|
Also seeing this behaviour, would be great to get this merged! |
stevehipwell
force-pushed
the
fix-branch-protection-churn
branch
from
a42bada to
1eebbb1
Compare
|
Bump! |
|
Also hitting this. - maybe @kfcampbell can help? |
|
@kfcampbell @nickfloyd |
stevehipwell
force-pushed
the
fix-branch-protection-churn
branch
from
1eebbb1 to
066cf52
Compare
stevehipwell
force-pushed
the
fix-branch-protection-churn
branch
from
066cf52 to
6233773
Compare
|
Bump 🙏🏼 |
|
@joaorpsoares you'd probably be better off switching over to rulesets as they (mostly) work and don't have this churn issue. |
Signed-off-by: Steve Hipwell <[email protected]>
stevehipwell
force-pushed
the
fix-branch-protection-churn
branch
from
6233773 to
7e8a8be
Compare
|
@nickfloyd this is a real pain point, albeit for a resource with a newer replacement. I could add a test to go with this, but I likely won't have time until the end of the week. |
nickfloyd
approved these changes
Oct 21, 2025
|
@stevehipwell Tests have been added here #2799 |
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in 🧰 Octokit Active
github-project-automation
bot
moved this from In Progress
to Done
in Terraform Provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2493
Before the change?
github_branch_protection_v3resource churned when when usingchecksorcontextsinrequired_status_checksAfter the change?
github_branch_protection_v3resourcePull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!