Skip to content

Conversation

@vedantthapa
Copy link

@vedantthapa vedantthapa commented Oct 3, 2025

GitHub API marks the repository parameter as required. Plus, not specifying it results in a malformed API request as the SDK uses it to construct the URL.


Before the change?

  • Unspecified repository results in an API call to a non-existent endpoint - https://api.github.com/repos/<owner>//rulesets.

After the change?

  • Unspecified repository should fail validation.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@vedantthapa
Copy link
Author

Noticed #2603 already exists, closing this.

@vedantthapa vedantthapa closed this Oct 5, 2025
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant