fix: error when updating ruleset without bypass actors #2824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2803
Before the change?
github_repository_rulesetthat never hadbypass_actorsdefined would fail with a422 Invalid request. Invalid property /bypass_actors: data cannot be null.errorUpdateRulesetNoBypassActor, which sendsbypass_actors: nullwhen the field was never defined, causing GitHub API to reject the requestAfter the change?
bypass_actorscan now be updated without errorsUpdateRulesetNoBypassActoronly whend.HasChange("bypass_actors")istruebypass_actorshasn't changed, usesUpdateRulesetwhich omits the field entirelyPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!