Skip to content

Conversation

@nickfloyd
Copy link
Contributor

Resolves #964
Resolves #2804

NOTE: Intended to be patched into v2.7.1 and merged into main.


Before the change?

  • Prior to this change there was no way to control actions secrets from either being or not being destroyed and created

After the change?

  • We can now use the destroy_on_drift property to indicate if we should recreate if the secret was modified outside of the context of the provider.
  • Fixes the a bug where destroyOnDrift=true (which is the default) and drift is detected, the code sets d.SetId("") but does NOT update the timestamp. This means on the next Terraform run, the old timestamp is still in state, so it will detect drift again, causing an infinite loop of "Provider produced inconsistent result" errors.

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@nickfloyd nickfloyd self-assigned this Oct 29, 2025
@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label Oct 29, 2025
@nickfloyd nickfloyd merged commit b15919c into main Oct 29, 2025
3 checks passed
@nickfloyd nickfloyd deleted the 964/add-destroy-on-drift branch October 29, 2025 18:30
@github-project-automation github-project-automation bot moved this from Backlog to Done in Terraform Provider Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented

Projects

2 participants