fix: Add destroy-on-drift property to the GitHub Action Secret resource schema #2842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #964
Resolves #2804
NOTE: Intended to be patched into v2.7.1 and merged into main.
Before the change?
After the change?
destroy_on_driftproperty to indicate if we should recreate if the secret was modified outside of the context of the provider.destroyOnDrift=true(which is the default) and drift is detected, the code sets d.SetId("") but does NOT update the timestamp. This means on the next Terraform run, the old timestamp is still in state, so it will detect drift again, causing an infinite loop of "Provider produced inconsistent result" errors.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!