Skip to content

Fixes #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from
Draft

Fixes #2999

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
333daf5
added test for plugins
drosetti Sep 10, 2025
8141a2e
fixed utc filter in history
drosetti Sep 11, 2025
ed6d2d2
added description to kill chain phases in user event
drosetti Sep 12, 2025
25c8ceb
customer dropdown for evaluation
drosetti Sep 12, 2025
5f109c9
improved user event modal tests
drosetti Sep 12, 2025
84ccf2b
prettier
drosetti Sep 12, 2025
cc3574a
used datamodel tags
drosetti Sep 17, 2025
901b0d6
renamed cost
drosetti Sep 17, 2025
bb1e47e
restored evaluation
drosetti Sep 17, 2025
2dda47b
added reliability message
drosetti Sep 17, 2025
174d89d
prettier
drosetti Sep 17, 2025
3cc27d0
fixes
carellamartina Sep 17, 2025
9530f27
fixed auto-populate form
drosetti Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions frontend/src/components/userEvents/UserEventModal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,19 +208,24 @@ export function UserEventModal({ analyzables, toggle, isOpen }) {
});

React.useEffect(() => {
// this useEffect populate initial state in case the model is accessed from previously searched analyzables
const obj = {};
formik.initialValues.analyzables.forEach((analyzable) => {
if (analyzable !== "") {
obj[analyzable] = { type: UserEventTypes.ANALYZABLE };
analyzables.forEach((analyzable) => {
if (analyzable.name !== "") {
obj[analyzable.name] = {
type: UserEventTypes.ANALYZABLE,
eventId: analyzable.id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I saved the new evaluation, the analyzable's data model was modified instead of the associated user event's data model. I think it's due to the id set in the eventId key

};
}
});
setInputState({ ...inputState, ...obj });
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [formik.initialValues.analyzables]);
}, [analyzables]);

useDebounceInput(inputValue, 1000, setWildcard);

React.useEffect(() => {
// this useEffect detect the type of user event while typing
if (wildcard !== "") {
// check ip wildcard
if (
Expand Down Expand Up @@ -311,7 +316,8 @@ export function UserEventModal({ analyzables, toggle, isOpen }) {
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [wildcard]);

console.debug(formik.values);
console.debug("userEventModal - formik values", formik.values);
console.debug("userEventModal - inputState", inputState);

return (
<Modal
Expand Down Expand Up @@ -504,7 +510,8 @@ export function UserEventModal({ analyzables, toggle, isOpen }) {
evaluationOptions.find(
(element) => element.evaluation === evCode,
).reliability,
false,
// second set must trigger the validate or update evaluation with pre-populated form won't work
true,
);
}}
className="bg-darker border-dark"
Expand Down
Loading