Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a basic implementation for shader material.
It can be extended once you pass this implementation, mainly to add new uniform types.
I think you have to implement your Script object first in order to be able to update uniform values since Render().
Sample file (is more a dev testing file that a sample file):
ThreePlus-Materials-11_Shader.zip
It has been a headache to synchronize my project with yours because I downloaded the project as a ZIP and your VS solution is inside a folder. I was able to fix it by re-downloading the project, this time with "Open with Visual Studio" and the cloning was successful. I've probably used a bad habit but it has worked for me so far. However when I copied and pasted my changes into the new properly cloned project, there was a formatting adjustment adding unnecessary spaces. Keep this in mind when reviewing the changes.