Skip to content

fix: make terms query that gets eitems by creator use correct keyword #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

fix: make terms query that gets eitems by creator use correct keyword #1253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion invenio_app_ils/eitems/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def get_eitems_for_document_by_creator(document_pid, creator, case_insensitive=F
document_pid=document_pid
).filter(
"term",
created_by__value={"term": creator, "case_insensitive": case_insensitive},
created_by__value={"value": creator, "case_insensitive": case_insensitive},
Copy link
Contributor

@kpsherva kpsherva Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be?

Suggested change
created_by__value={"value": creator, "case_insensitive": case_insensitive},
created_by={"value": creator, "case_insensitive": case_insensitive},

Copy link
Contributor Author

@JakobMiesner JakobMiesner Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpsherva created_by is an object that contains value. The second "value" inside curly braces is an OS keyword.
See here for the mapping.

image

)

return creator_match
Expand Down
Loading