chore: extract evaluate_record_deletion into utils #3201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlinmack
force-pushed
the
refactor-rec-del
branch
from
ed7cb5f to
0cab183
Compare
slint
reviewed
Oct 14, 2025
carlinmack
force-pushed
the
refactor-rec-del
branch
from
0cab183 to
1b21417
Compare
carlinmack
force-pushed
the
refactor-rec-del
branch
from
1b21417 to
6b4621c
Compare
carlinmack
force-pushed
the
refactor-rec-del
branch
from
6b4621c to
e193a1e
Compare
ntarocco
reviewed
Oct 28, 2025
|
|
||
| def evaluate_record_deletion(record: RDMRecord): | ||
| """Evaluate whether a given record can be deleted by an identity.""" | ||
| rec_del = RDMRecordDeletionPolicy().evaluate(g.identity, record._record) |
| return list(existing_requests)[0] | ||
|
|
||
|
|
||
| def evaluate_record_deletion(record: RDMRecord): |
There was a problem hiding this comment.
Is this the same changes as in the other PR (it might include the same commit)?
There was a problem hiding this comment.
yes sorry the other PR includes this PR and #3200 as I presume they could be merged first. sorry for the confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: