Skip to content

Conversation

@sakshamarora1
Copy link
Contributor

  • Also, prevents deletions of other GroupFields because of the close button being triggered on Enter key press for some reason
Screen.Recording.2025-11-03.at.14.47.55.mov

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

* Also, prevents deletions of other GroupFields because of the close button being triggered on Enter key press for some reason
@sakshamarora1 sakshamarora1 moved this to In review 🔍 in Sprint Q4/2025 Nov 3, 2025
@palkerecsenyi palkerecsenyi self-assigned this Nov 3, 2025
Copy link
Member

@palkerecsenyi palkerecsenyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I can't find any other more "official" way to do this in the Formik docs so I think this is the best solution. I've tested it briefly and cannot find any adverse effects, it seems correct to me.

p.s. please add the missing semicolon to fix the CI :)

@palkerecsenyi palkerecsenyi removed their assignment Nov 3, 2025
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I assume no accessibility issues, since it's local to the "leaf" nodes of nested forms.

@slint slint moved this from In review 🔍 to To release 🤖 in Sprint Q4/2025 Nov 7, 2025
@palkerecsenyi
Copy link
Member

FYI Saksham found some issues with the enter key not working to click on buttons around the form. So this is still a WIP for now

@palkerecsenyi palkerecsenyi moved this from To release 🤖 to In progress in Sprint Q4/2025 Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

3 participants