fix,feat: canvas followups 3 #6824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `syncZIndices` to `CanvasEntityAdapterBase` to arrange each layer's konva nodes appropriately.
This includes some fixes for the composite number input component's local value handling, resolving an infinite recursion problem when an invalid value is set.
- Add `reset` functionality - Rename badly named `autoPreviewFilter` to `autoProcessFilter` - Do not process filter when starting, unless `autoProcessFilter` is enabled
Similar behaviour to before. When on, snaps to 64. If ctrl/cmd held, snap to 8.
psychedelicious
requested review from
blessedcoolant,
hipsterusername and
maryhipp
as code owners
hipsterusername
approved these changes
Sep 9, 2024
github-actions
bot
added
frontend-deps
This makes it a bit slower to switch tabs but also eliminates a whole class of bugs related to rendered but hidden components.
Need to figure out why the rect isn't reset when the entity is reset. Probably just needs some special handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Misc canvas followups. See commits for details.
Related Issues / Discussions
Discord/offline discussions.
QA Instructions
Try the things in the commits.
Merge Plan
n/a
Checklist