fix(ui): gallery grid calculation #6889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue w/ the calculation causing an infinite loop but the fixed algorithm wasn't correct bc it doesn't take into account the grid gap correctly. This then breaks arrow key navigation. - Restore the previous calculation - Bail out if the gallery elements don't have any width, which causes the infinite loop - this part was missed when copying the logic from GalleryImageGrid
psychedelicious
requested review from
blessedcoolant,
hipsterusername and
maryhipp
as code owners
blessedcoolant
approved these changes
Sep 19, 2024
|
LGTM |
On second check, what is breaking here exactly? I am not able to see any functional difference between the two. Unless I'm missing something? Also ... the while loop performance is very bad compared to when not using it. And I am not exactly sure what is breaking with the older code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was an issue w/ the calculation causing an infinite loop but the fixed algorithm from #6887 wasn't correct bc it doesn't take into account the grid gap correctly. This then breaks arrow key navigation.
Related Issues / Discussions
n/a
QA Instructions
shouldn't freeze
Merge Plan
n/a
Checklist