Taxonomy #7833
Merged
Taxonomy #7833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
api
python
added 3 commits
March 26, 2025 12:30
jazzhaiku
requested review from
blessedcoolant,
brandonrising,
ebr,
hipsterusername,
lstein and
psychedelicious
as code owners
psychedelicious
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Nice!
We have a number of places where were import modules dynamically - for example, when using if TYPE_CHECKING: or in certain functions.
I'm not confident in the IDE's ability handle these imports, so I searched the codebase for instances of such dynamic imports (^[ \t]+(?:import|from).* over *.py files).
All looks good - there are only a couple places where these dynamic imports were importing taxonomy stuff anyways.
hipsterusername
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves type definitions out of
config.pyinto a newtaxonomy.pymodule.The goal is to reduce clutter in
config.py, and to resolve circular import issues by isolating these types in a dedicated module with (almost) no internal dependencies.Because so many places import these definitions, these changes touch 73 files.
Additional changes:
.git-blame-ignore-revsto avoid noise in git blame historyRelated Issues / Discussions
QA Instructions
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)