Skip to content

Conversation

@psychedelicious
Copy link
Collaborator

Summary

ci: add check for uv lockfile consistency with pyproject.toml

Related Issues / Discussions

Inconsistency noted on discord by @keturn:
https://discord.com/channels/1020123559063990373/1049495067846524939/1360297727447011601

QA Instructions

We have an inconsistency, so this PR should fail the check. I'll push a fixed lockfile after it fails, and confirm the updated lockfile lets the check pass.

Merge Plan

Once pushed, we should add this check to the required checks for PR.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the CI-CD Continuous integration / Continuous delivery label Apr 13, 2025
@github-actions github-actions bot added Root python-deps PRs that change python dependencies labels Apr 13, 2025
@psychedelicious psychedelicious marked this pull request as draft April 13, 2025 23:48
@psychedelicious psychedelicious marked this pull request as ready for review April 13, 2025 23:48
@psychedelicious
Copy link
Collaborator Author

I triggered the workflow by pushing a change to pyproject.toml, changing the project description. The workflow detected a change to pyproject.toml and ran the check. It failed as expected. I reverted that change, then updated the lockfile. The workflow was triggered by the change to uv.lock and ran the check. It succeeded as expected.

Think this is good to go. Will need @hipsterusername to add the new check to the required checks for merge to main (after this PR merges)

@psychedelicious psychedelicious merged commit 03ca23b into main Apr 14, 2025
12 checks passed
@psychedelicious psychedelicious deleted the psyche/ci/uvlock-pyprojecttoml branch April 14, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-CD Continuous integration / Continuous delivery python-deps PRs that change python dependencies Root

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants