-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix(nodes): color correct invocation #8605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
psychedelicious
merged 15 commits into
invoke-ai:main
from
dunkeroni:fix_color_correct_invocation
Oct 9, 2025
Merged
Fix(nodes): color correct invocation #8605
psychedelicious
merged 15 commits into
invoke-ai:main
from
dunkeroni:fix_color_correct_invocation
Oct 9, 2025
+95
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dunkeroni <[email protected]>
Co-authored-by: dunkeroni <[email protected]>
Co-authored-by: dunkeroni <[email protected]>
Co-authored-by: dunkeroni <[email protected]>
…nding Co-authored-by: dunkeroni <[email protected]>
…erting mask Co-authored-by: dunkeroni <[email protected]>
psychedelicious
approved these changes
Oct 9, 2025
Contributor
psychedelicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
frontend
PRs that change frontend files
invocations
PRs that change invocations
python
PRs that change python files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Existing ColorCorrectInvocation does not work. It triggers an error if no mask is provided, and when a mask is provided the result is an imagechops.mulitply of the mask and the two inputs, not outputting any actual corrected region.
Refactored node has the following changes:
Color space options will depend on use case. Since channels are corrected independently, the output can have combinations across multiple channels that do not appear in the inputs. This is a bigger issue in RGB, hence the option for YCbCr. From testing a few scenarios, RGB seems to do better when decreasing saturation/contrast, and YCbCr does better when restoring it.
Related Issues / Discussions
Closes #4770
Relevant discussions and mentions of broken node:
https://discord.com/channels/1020123559063990373/1130288930319761428/1424817011204292618
https://discord.com/channels/1020123559063990373/1345587047229816832/1422940609295159504
https://discord.com/channels/1020123559063990373/1178755835162267658/1178755835162267658
QA Instructions
Applied corrections for each colorspace option across multiple degradation methods and resolution combinations.
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)