feat: reidentify model #8618
Merged
feat: reidentify model #8618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add route and model record service method to reidentify a model. This re-probes the model files and replaces the model's config with the new one if it does not error.
psychedelicious
requested review from
blessedcoolant,
hipsterusername,
lstein and
maryhipp
as code owners
github-actions
bot
added
api
python
hipsterusername
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a button to the model manager to reidentify a model.
When we are unable to identify a model, it gets installed as Unknown. If we implement support for that model in the future, and the user hasn't deleted the model by then, they can reidentify the unknown model and it should work.
I also fixed an issue with model installation.
There is a heuristic that checks how many files are in a model folder as a way to protect against the user accidentally "installing" a big directory as a model (e.g. user installs C:\ drive). It does this by counting the number of files and folder hierachy depth, bailing out there are too many files or too-deeply-nested model files.
That heuristic didn't ignore hidden directories, so if you had something like a
.gitdir from a HF-cloned repo, the model manager would think this is not a real model and error.It now correctly ignores files in hidden directories.
Related Issues / Discussions
n/a
QA Instructions
n/a
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)