-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Separate timeout from interval in location watch #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Separate timeout from interval in location watch #8
Conversation
So that users don't get timeout e.g. in resolving pre-conditions like turning on location. References: https://outsystemsrd.atlassian.net/browse/RMET-4688
|
Test results: I noticed that when adding a watch, receiving location updates, and then clearing the watch, it seems that the location service continues turned on (the icon for the location keeps showing in the status bar). I believe this didn't used to happen, so it might be something we want to look into. |
|
@alexgerardojacinto thanks for reporting this. The native library was wrongly creating two watches, and so when calling Fixed in fed5bfe - if you'd like to review now 🙇 |
|
@OS-pedrogustavobilro I was re-testing it but I think the .apk file in the PR's description may need to be updated right? |
|
@alexgerardojacinto apologies, forgot about that... Updated apk and zip files in PR description |
|
@OS-pedrogustavobilro no worries, thank you! Just tested it now and it now works properly on my end! |
OS-ruimoreiramendes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the apk on android studio emulator and it works fine.
Description
This PR adds native timeout functionality to
watchPosition.Also, in order to allow more configurability in
watchPosition, allow to configure anintervalparameter, instead of using just thetimeout. By defaultintervalis equal totimeout, to maintain backwards-compatible behavior.Context
https://outsystemsrd.atlassian.net/browse/RMET-4688
Type of changes
Tests
Updated and added new unit tests to reflect the changes.
You may test with this sample Location App (updated 5 nov 2025) - apk file, or get the source code and build in Android Studio
Checklist