chore(*): add remaining StructTag getters and ctors
#334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex6323
changed the title
StructTag ctorsStructTag getters and ctors
DaughterOfMars
approved these changes
Oct 21, 2025
Thoralf-M
reviewed
Oct 27, 2025
DaughterOfMars
approved these changes
Oct 27, 2025
DaughterOfMars
approved these changes
Oct 28, 2025
|
I will review this quickly before it's merged please |
Thoralf-M
approved these changes
Oct 30, 2025
| add_struct_tag_ctor_from_type_tag!(FRAMEWORK, "balance", "Balance"); | ||
| add_struct_tag_ctor_from_type_tag!(FRAMEWORK, "timelock", "TimeLock"); | ||
| add_struct_tag_ctor_from_type_tag!(FRAMEWORK, "config", "Setting", "with-module"); | ||
| add_struct_tag_ctor_from_type_tag!(FRAMEWORK, "dynamic_object_field", "Wrapper", "with-module"); |
There was a problem hiding this comment.
I still don't like the string differencier but that's fine
There was a problem hiding this comment.
at least we can change that part later without a breaking change.
thibault-martinez
approved these changes
Oct 30, 2025
Alex6323
added a commit
that referenced
this pull request
Nov 3, 2025
* add ctors * add getters * update libs * add ctors to bindings * Apply suggestion from @thibault-martinez * make 3 * add remaining 5 * new_iota_coin_name * some ux improvements and additional struct tags * iota coin TYPE --------- Co-authored-by: Thibault Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #259
Also adds remaining constructors. I prepended the constructors with
new_, so it becomes easier to distinguish them from the getters.