feat(tx-builder): Unify gas methods and improve/update docs #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex6323
changed the title
.gas_multi.gas_coins docs
Alex6323
changed the title
.gas_coins docs .gas_coins docs
|
Honestly I'd rather just accept an array in |
sure about it? Most users will just pass one coin, and they'ld then have to deal with array syntax all the time. Providing an extra "multi" version is quite common in the monorepo, but 🤷♂️ @Thoralf-M @thibault-martinez opinions? |
Thoralf-M
reviewed
Oct 27, 2025
|
I also prefer a single |
Alex6323
changed the title
.gas_coins docs
Thoralf-M
approved these changes
Oct 30, 2025
* feat(ci): add links checker * remove PR
* feat(iota-transaction-builder): improve send_coins docs * hide main fn * update bindings * update import * clarify that all coins must have the same type * remove brackets
DaughterOfMars
approved these changes
Nov 3, 2025
thibault-martinez
approved these changes
Nov 3, 2025
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gas()for single gas coins.gas_coins()to.gas()to now always allow to provide multiple gas coins.Closes #291