feat(consensus): refactor Cordial Knowledge to speed up access to ConnectionKnowledge #9009
+430
−383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
polinikita
force-pushed
the
consensus/feat/refactor-cordial-knowledge-for-faster-access
branch
from
9278093 to
d0761ab
Compare
polinikita
changed the title
piotrm50
approved these changes
Oct 29, 2025
github-actions
bot
added
documentation
polinikita
force-pushed
the
consensus/feat/refactor-cordial-knowledge-for-faster-access
branch
from
d183c98 to
3d69882
Compare
polinikita
requested review from
VorobyevIlya and
filipdulic
and removed request for
a team
|
✅ Vercel Preview Deployment is ready! |
polinikita
removed
documentation
polinikita
force-pushed
the
consensus/feat/refactor-cordial-knowledge-for-faster-access
branch
from
a096d56 to
e646e88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Currently, each Connection Knowledge is coordinated by one task and communication with that taks is done using tokio bounded channels. Instead, we propose to use shared access with parking_lot::RwLock for faster access of internal structs. This change implies some refactoring for CordialKnowledge as well. In short, the PR reduces the number of async tasks spawned by CordialKnowledge to two (from committee_size), improving the time needed to create a block bundle when streaming.
Links to any relevant issues
Fixes #9036
How the change has been tested