Skip to content

Add a bool Flush property to MfsWriteOptions #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2024
Merged

Add a bool Flush property to MfsWriteOptions #38

merged 2 commits into from
Sep 14, 2024

Conversation

Arlodotexe
Copy link
Collaborator

@Arlodotexe Arlodotexe commented Sep 14, 2024 •
edited
Loading

Add a Flush property to MfsWriteOptions class.

  • Add a new property Flush of type bool? with a default value of null.
  • Document the Flush property in the class summary.
  • Add remarks to the Flush property to caution about performance and consistency trade-offs.

Note that this flag is mentioned in the Kubo CLI docs, but not the Kubo RPC HTTP API docs.

@Arlodotexe Arlodotexe merged commit 57dffd3 into main Sep 14, 2024
1 check passed
@Arlodotexe Arlodotexe deleted the mfs/add-flush-property branch September 14, 2024 05:26
@Arlodotexe Arlodotexe mentioned this pull request Sep 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Arlodotexe