Open
Conversation
tgymnich
force-pushed
the
tim/apply-expr
branch
2 times, most recently
from
f3c53fd to
472270a
Compare
ftynse
reviewed
Feb 11, 2026
Comment on lines
670
to
674
| // Accept both WaveTensorType (before PropagateElementsPerThread) and | ||
| // 1D vectors (after). We cannot use Variadic<WaveTensorInRegister> because | ||
| // Variadic requires a Type and not a TypeConstraint. | ||
| let arguments = !con((ins | ||
| Arg<Variadic<WaveIterableType>, "Input registers">:$arguments, |
Contributor
There was a problem hiding this comment.
This does use WaveIterableType though, which I suspect is a workaround
Contributor
There was a problem hiding this comment.
TODO @ftynse : it seems possible to define Type instead of TypeConstraint to solve this locally. Take inspiration from what is done with Attr in this PR.
| // Variadic requires a Type and not a TypeConstraint. | ||
| let arguments = !con((ins | ||
| Arg<Variadic<WaveIterableType>, "Input registers">:$arguments, | ||
| Arg<WaveExprListAttr, "Expression to apply">:$expr |
Contributor
There was a problem hiding this comment.
At this point, we should just have a WaveExprAttr (which may internally be a list + verifier for single result, but I'm not even sure we still need actual lists).
Contributor
|
Taking this over |
ftynse
reviewed
Feb 13, 2026
- use direct positional encoding of operands instead of names and unnecessary ordering constraints - fix tests - introduce an attribute constraint to restrict the kinds of symbols that may appear in index expressions, use it for various ops Signed-off-by: Alex Zinenko <git@ozinenko.com>
via direct expansion of affine expressions Signed-off-by: Alex Zinenko <git@ozinenko.com>
Signed-off-by: Alex Zinenko <git@ozinenko.com>
ftynse
force-pushed
the
tim/apply-expr
branch
from
ef76a32 to
126040f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.