Open
Conversation
Contrary to what the type annotation on hardware constraint says, `vector_shapes` is being used with expressions on the right-hand side. Try to resolve those using the substitution dictionary before export to avoid triggering cast errors when constructing MLIR that does enforce this constraint. We can separately revisit the need to have expressions in vector shapes. Signed-off-by: Alex Zinenko <git@ozinenko.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrary to what the type annotation on hardware constraint says,
vector_shapesis being used with expressions on the right-hand side. Try toresolve those using the substitution dictionary before export to avoid
triggering cast errors when constructing MLIR that does enforce this
constraint. We can separately revisit the need to have expressions in vector
shapes.