Refactored to support PSR-4 & IronCore 1.0.*#12
Open
dirx wants to merge 2 commits intoiron-io:masterfrom
Open
Conversation
added 2 commits
July 20, 2015 17:29
+ removed common temp & ide config files - best practise ist to add them to ~/.gitignore_global + added vendor dir
+ moved classes to /src folder + moved test into /test folder + removed phar & build.php
Contributor
|
@dirx thanks! i'll review and merge |
|
Looks like this needs to be rebased. @thousandsofthem would you actually merge if I went ahead and redid this pull request? |
Contributor
|
yes, i will. thanks |
|
Was this ever progressed as this library is not compatible with Iron core after upgrading Iron MQ to 2.*? |
Contributor
|
it'll just switch to different iron_core branch (from current outdated one) |
|
Still on my radar since I need to implement this for php-queuesadilla. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did some cleanup, added support for namespace and IronCore 1.0.*.
README still needs an update.
Hope this groundwork helps for your next release 1.0.0.