Skip to content

Close the socket listener explicitly #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2025
Merged

Close the socket listener explicitly #663

merged 1 commit into from
Nov 25, 2025

Conversation

@Rohit-0505
Copy link
Contributor

@Rohit-0505 Rohit-0505 commented Nov 20, 2025 •
edited
Loading

Proposed Changes

  • Update the grpcServer runner to close the socket listener explicitly when server stops
  • Bump latest envtest, golangci-lint and controller-gen version

@Rohit-0505 Rohit-0505 requested a review from a team as a code owner November 20, 2025 08:18
@github-actions github-actions bot added size/S enhancement New feature or request labels Nov 20, 2025
@Rohit-0505 Rohit-0505 self-assigned this Nov 20, 2025
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/enh/grpcServer-socket-close branch from cf3515a to 8d0079f Compare November 21, 2025 05:26
@hardikdr hardikdr added this to Roadmap Nov 21, 2025
@lukasfrank lukasfrank changed the title update the grpcServer runner to close the socket listener explicitly Close the socket listener explicitly Nov 24, 2025
@lukasfrank lukasfrank added invalid This doesn't seem right integration-tests to run integration tests ok-to-image and removed invalid This doesn't seem right labels Nov 24, 2025
@lukasfrank lukasfrank merged commit b3d7017 into ironcore-dev:main Nov 25, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this to Done in Roadmap Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasfrank lukasfrank lukasfrank approved these changes

@afritzler afritzler Awaiting requested review from afritzler

Assignees

@Rohit-0505 Rohit-0505

Labels

area/compute enhancement New feature or request integration-tests to run integration tests ok-to-image size/S

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rohit-0505 @lukasfrank @hardikdr