Skip to content

Conversation

jaybdub
Copy link

@jaybdub jaybdub commented Sep 24, 2025

Description

This PR adds the following changes

  1. Adds support for rendering images to Locomanipulation SDG envs
  2. Renames DisjointNav -> LocomanipulationSDG in docs and code

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added documentation Improvements or additions to documentation isaac-mimic Related to Isaac Mimic team labels Sep 24, 2025
@jaybdub jaybdub changed the title add camera to g1 locomanipulation env add camera to g1 locomanipulation env and update docs with G1.5 training note Oct 2, 2025
@yanchangNvidia
Copy link
Contributor

Please add how you tested these changes.

@yanchangNvidia
Copy link
Contributor

@ooctipus to review.

@jaybdub
Copy link
Author

jaybdub commented Oct 3, 2025

@yanchangNvidia -- These changes were tested by

  1. Running the datageneration pipeline with sample data
  2. Plotting the output trajectory
  3. Viewing images from dataset

Copy link
Contributor

@yanchangNvidia yanchangNvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. Thank you for the changes. Left a few comments.

you may convert the generated dataset to LeRobot format as expected by GR00T N1.5, and then run the finetuning script provided
in the GR00T N1.5 repository. An example closed-loop policy rollout is shown in the video below:

.. figure:: https://download.isaacsim.omniverse.nvidia.com/isaaclab/images/locomanipulation_sdg_disjoint_nav_groot_policy_4x.gif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change this gif name to "locomanipulation_sdg_groot_policy_4x.gif"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can but we need to ask for these images to be re-uploaded, I don't have direct access to do this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Who can help us to get these images re-uploaded?

## Usage

To run the locomanipulation SDG replay script execute the following command.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need another step of running manipulation trajectory augmentation before the navigation trajectory augmentation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not needed, but desired. The script is generic, it can use the teleop dataset directly, or instead use the manipulation augmented trajectory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. It would be great to add this information as a part of the documentation so that users know that they can use have another step to do the manipulation augmented trajectory before this step to scale up the data.

@Mayankm96 Mayankm96 changed the title add camera to g1 locomanipulation env and update docs with G1.5 training note Adds camera to G1 Steering Wheel environment Oct 10, 2025
spawn=sim_utils.DomeLightCfg(color=(0.75, 0.75, 0.75), intensity=3000.0),
)

robot_pov_cam = CameraCfg(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this is not the tiled camera class. For that, you need to use TiledCamera.

Copy link
Contributor

@yanchangNvidia yanchangNvidia Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mayankm96 Great catch. @jaybdub Will this affect the data generation pipeline throughput without TiledCamera?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally named the USD path "tiled_camera" based on an older version where I used TiledCamera.

However, I updated this to use the Camera class to emulate the existing manipulation environments:

The code is intended, so I've updated the USD path so the name is "camera" to make it less confusing.

Copy link
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that others have checked that the code works correctly and all the documentation is correct as well. Left a minor note on TiledCamera vs Camera.

@Mayankm96 Mayankm96 added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Oct 10, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 13, 2025
Copy link
Contributor

@michaellin6 michaellin6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Need to address Mayank's comment on TiledCamera, but besides that it LGTM

@kellyguo11 kellyguo11 merged commit 3de863a into isaac-sim:release/2.3.0 Oct 14, 2025
1 of 2 checks passed
kellyguo11 added a commit that referenced this pull request Oct 14, 2025
# Description

#3549 introduced some linter issues. fixing them here with the
formatter.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)


## Checklist

- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request isaac-mimic Related to Isaac Mimic team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants