-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Adds camera to G1 Steering Wheel environment #3549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds camera to G1 Steering Wheel environment #3549
Conversation
Please add how you tested these changes. |
@ooctipus to review. |
@yanchangNvidia -- These changes were tested by
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great. Thank you for the changes. Left a few comments.
you may convert the generated dataset to LeRobot format as expected by GR00T N1.5, and then run the finetuning script provided | ||
in the GR00T N1.5 repository. An example closed-loop policy rollout is shown in the video below: | ||
|
||
.. figure:: https://download.isaacsim.omniverse.nvidia.com/isaaclab/images/locomanipulation_sdg_disjoint_nav_groot_policy_4x.gif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change this gif name to "locomanipulation_sdg_groot_policy_4x.gif"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can but we need to ask for these images to be re-uploaded, I don't have direct access to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Who can help us to get these images re-uploaded?
## Usage | ||
|
||
To run the locomanipulation SDG replay script execute the following command. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need another step of running manipulation trajectory augmentation before the navigation trajectory augmentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not needed, but desired. The script is generic, it can use the teleop dataset directly, or instead use the manipulation augmented trajectory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. It would be great to add this information as a part of the documentation so that users know that they can use have another step to do the manipulation augmented trajectory before this step to scale up the data.
...asks/isaaclab_tasks/manager_based/locomanipulation/pick_place/locomanipulation_g1_env_cfg.py
Show resolved
Hide resolved
source/isaaclab_mimic/isaaclab_mimic/locomanipulation_sdg/envs/__init__.py
Outdated
Show resolved
Hide resolved
spawn=sim_utils.DomeLightCfg(color=(0.75, 0.75, 0.75), intensity=3000.0), | ||
) | ||
|
||
robot_pov_cam = CameraCfg( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this is not the tiled camera class. For that, you need to use TiledCamera
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mayankm96 Great catch. @jaybdub Will this affect the data generation pipeline throughput without TiledCamera?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accidentally named the USD path "tiled_camera" based on an older version where I used TiledCamera.
However, I updated this to use the Camera
class to emulate the existing manipulation environments:
Line 161 in 2d80bd8
robot_pov_cam = CameraCfg( |
The code is intended, so I've updated the USD path so the name is "camera" to make it less confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that others have checked that the code works correctly and all the documentation is correct as well. Left a minor note on TiledCamera vs Camera.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Need to address Mayank's comment on TiledCamera, but besides that it LGTM
# Description #3549 introduced some linter issues. fixing them here with the formatter. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
Description
This PR adds the following changes
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there