-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Adds friction force reporting to ContactSensor #3563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gattra-rai
wants to merge
32
commits into
isaac-sim:main
Choose a base branch
from
gattra-rai:friction-forces
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+309
−58
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
1e1e6e0
removed redundant buffer
gattra-rai e9c9f47
added friction force tracking
gattra-rai e2a9f43
added friction force shape test
gattra-rai ac32441
added non contact test
gattra-rai 1aad6c1
validating non nan
gattra-rai fa22e40
test to validate vectorized solution
gattra-rai 0e4f6d4
formatting
gattra-rai c78c80c
updating doc / version
gattra-rai ab095a9
rename func to be more generic
gattra-rai eee4822
added to contributors
gattra-rai 664056b
test to check that friction forces make sense
gattra-rai 30a7b5d
formatting
gattra-rai 3d5099c
tuned forces in test
gattra-rai 91509ca
adds back friction tracking to check sensor script
gattra-rai 23b00ce
docstring / typing
gattra-rai 428272c
formatting
gattra-rai 646bdcb
test comparing elements of physx friction data with reported sensor f…
gattra-rai 058c6dc
tighter threshold for comparison
gattra-rai 817ed3f
resetting to zeros
gattra-rai a20d58c
tests pass
gattra-rai d81d398
add param to docstring
gattra-rai 51c4f63
comment formatting
gattra-rai 6c0441e
setting gravity in sim cfg
gattra-rai 53aed8a
remove unused imports
gattra-rai 1fbdb77
formatter
gattra-rai 536b4a5
updated tests
gattra-rai 0337606
removed unhelpful comment
gattra-rai 9972b9b
addressing pr comments
gattra-rai 6e6486e
using torch.testing / working on test for invalid config
gattra-rai 551a245
config tests
gattra-rai 1ed5152
atol/rtol
gattra-rai a4b0c83
updated docstring
gattra-rai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.