Fixes skrl train/play script configurations when using the --agent argument and rename agent configuration variable
#3643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toni-SM
requested review from
Mayankm96,
hhansen-bdai,
kellyguo11 and
ooctipus
as code owners
kellyguo11
changed the title
--agent argument and rename agent configuration variable --agent argument and rename agent configuration variable
kellyguo11
approved these changes
Oct 13, 2025
ooctipus
approved these changes
Oct 14, 2025
kellyguo11
pushed a commit
that referenced
this pull request
Oct 15, 2025
…argument and rename agent configuration variable (#3643) # Description This PR address the following points: * Fix skrl train/play script configuration when using the `--agent` argument Example: ```bash python scripts/reinforcement_learning/skrl/train.py --task Isaac-Cart-Double-Pendulum-Direct-v0 --headless --agent skrl_mappo_cfg_entry_point ``` Error: ``` [INFO]: Parsing configuration from: isaaclab_tasks.direct.cart_double_pendulum.cart_double_pendulum_env:CartDoublePendulumEnvCfg [INFO]: Parsing configuration from: /home/toni/Documents/RL/toni_IsaacLab/source/isaaclab_tasks/isaaclab_tasks/direct/cart_double_pendulum/agents/skrl_mappo_cfg.yaml [INFO] Logging experiment in directory: /home/toni/Documents/RL/toni_IsaacLab/logs/skrl/cart_double_pendulum_direct Error executing job with overrides: [] Traceback (most recent call last): File "/home/toni/Documents/RL/toni_IsaacLab/source/isaaclab_tasks/isaaclab_tasks/utils/hydra.py", line 101, in hydra_main func(env_cfg, agent_cfg, *args, **kwargs) File "/home/toni/Documents/RL/toni_IsaacLab/scripts/reinforcement_learning/skrl/train.py", line 156, in main log_dir = datetime.now().strftime("%Y-%m-%d_%H-%M-%S") + f"_{algorithm}_{args_cli.ml_framework}" ^^^^^^^^^ NameError: name 'algorithm' is not defined ``` * Replace `STATES` by `OBSERVATIONS` when defining skrl's agent configuration model inputs to ensure a smooth and error-free transition when the new mayor version of **skrl** gets released. In such mayor version `OBSERVATIONS` and `STATES` have different value/usage. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR address the following points:
Fix skrl train/play script configuration when using the
--agentargumentExample:
Error:
Replace
STATESbyOBSERVATIONSwhen defining skrl's agent configuration model inputs to ensure a smooth and error-free transition when the new mayor version of skrl gets released. In such mayor versionOBSERVATIONSandSTATEShave different value/usage.Type of change