Skip to content

Fixes warnings when running AutoMate env #3660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 14, 2025
Merged

Fixes warnings when running AutoMate env #3660

merged 12 commits into from
Oct 14, 2025
+22 −52

Conversation

yijieg
Copy link
Collaborator

@yijieg yijieg commented Oct 9, 2025 •
edited by Mayankm96
Loading

Description

  • Fixes the warning messages reported in the QA testing
  • Remove redundant config argument 'sample_from'
  • Change the default value of config argument 'num_log_traj'

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@yijieg yijieg requested a review from kellyguo11 as a code owner October 9, 2025 21:58
@github-actions github-actions bot added the isaac-lab Related to Isaac Lab team label Oct 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2025 •
edited
Loading

Test Results Summary

2 547 tests   2 087 ✅  2h 30m 4s ⏱️
   96 suites    460 💤
    1 files        0 ❌

Results for commit c2d74ff.

♻️ This comment has been updated with latest results.

Mayankm96
Mayankm96 reviewed Oct 10, 2025
View reviewed changes
@kellyguo11 kellyguo11 changed the title Fix warnings when running AutoMate env Fixes warnings when running AutoMate env Oct 13, 2025
@kellyguo11 kellyguo11 merged commit 2d80bd8 into main Oct 14, 2025
11 checks passed
@kellyguo11 kellyguo11 deleted the dev/automate_warning branch October 14, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mayankm96 Mayankm96 Mayankm96 left review comments

@kellyguo11 kellyguo11 kellyguo11 approved these changes

Assignees

No one assigned

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yijieg @kellyguo11 @Mayankm96