fix locking pids_lock timing of do_exit #2300
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Unfortunately this violates the lock ordering of always taking a task group lock after taking pids_lock. |
Contributor
Author
|
@tbodt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have corrected the timing of locking the pids_lock in the do_exit function to be before mm_release.
The reason for this fix is that there was a potential for invalid memory access when executing processes related to /proc/{pid}, specifically when memory for the struct task member is freed during the process (this issue occurred during the execution of tmux). Additionally, there was a problem where resources locked during operations on /proc/{pid} were being released in do_exit, leading to further issues, so I addressed and fixed that as well.