Document title parameter and improve error handling for /new API#1058
Merged
jelmer merged 1 commit intoisso-comments:masterfrom Jul 18, 2025
Merged
Document title parameter and improve error handling for /new API#1058jelmer merged 1 commit intoisso-comments:masterfrom
jelmer merged 1 commit intoisso-comments:masterfrom
Conversation
pkvach
force-pushed
the
fix/new-api-title-parameter
branch
from
b7421d4 to
df75a3b
Compare
jelmer
approved these changes
Jul 17, 2025
Member
jelmer
left a comment
jelmer
left a comment
There was a problem hiding this comment.
Changes look good to me, but let's fix the CI before we land anything new.
Contributor
Author
Thanks for the quick review! |
Member
That would be great - thanks! |
Contributor
Author
|
I've created a pull request related to the CI here: #1059 |
Member
|
Can you rebase this, and then we can land it? |
…for /new API - Update API documentation to include optional title parameter for new comments. - Change error handling: when creating the first comment for a new thread, return a BadRequest if the URI is inaccessible and no title is provided, prompting the user to supply a title. Fixes isso-comments#1055
pkvach
force-pushed
the
fix/new-api-title-parameter
branch
from
df75a3b to
ca7b15e
Compare
Contributor
Author
Thanks! I've just rebased the branch — ready for another look. |
ix5
added
server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.rstbecause this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
titleparameter for new comments.BadRequestif the URI is inaccessible and no title is provided, prompting the user to supply a title.Why is this necessary?
Fixes #1055