Avoid an error if Offset.update() hasn't been called yet.#1070
Merged
jelmer merged 1 commit intoisso-comments:masterfrom Oct 28, 2025
Merged
Avoid an error if Offset.update() hasn't been called yet.#1070jelmer merged 1 commit intoisso-comments:masterfrom
Offset.update() hasn't been called yet.#1070jelmer merged 1 commit intoisso-comments:masterfrom
Conversation
jelmer
approved these changes
Oct 28, 2025
Contributor
Author
|
The E2E test failures seem unrelated to this change. |
Member
Yeah, see #1068 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1069.
Checklist
CHANGES.rstbecause this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
This fixes a bug where
Offset.localTime()will throw an error if called beforeOffset.update().Why is this necessary?
#1069