Fix Windows symlinks is-outside-dir bug #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mm. looks like tests are doing something wrong. |
3rd attempt. cloned, checked locally, but I'm on a customer's computer and for some reason github does not let me push to my own cloned repo because of some SSO mess-up, so I push it yet again via the online editor... :P
|
lol. the project's own test suite fails on |
WTF. and this time the right file!
osher
commented
Feb 22, 2021
|
|
||
| t.test('is not fooled by junctions (win32)', async t => { | ||
| const origRealPathSync = fs.realpathSync; | ||
| fs.realpathSync = s => s.replace(/symlink/, 'truedir'); |
There was a problem hiding this comment.
LMK if you prefer stubbing fs.realpathSync as part of testHelper
osher
changed the title
|
knock, knock? anyone home? |
|
@mojavelinux @isaacs @xdissent @shernshiou anybody home? |
1 task
|
@osher I do not maintain this project. Please do not ping me. |
|
Sorry, I thought that the auto-completion for tags offers the maintainers... 😛 |
|
How do I find the maintainers.... maybe I'll try frequent committers... |
|
anybody home 😮 |
|
ECHO echo (echo) (...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #46
The motive is: istanbuljs/nyc#1381