fix(perf): Improve performance by converting patterns to regexp only once #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve profiled a
c8 mocharun against a huge test suite (5000+ tests) which spotted theminimatchcall withinshouldInstrumentas a bottleneck. SinceshouldInstrumentis called quite often but the theexcludepatterns don’t change over time a lot of CPU time is wasted parsing the same glob patterns again and again.This change converts all glob pattern to regex patterns in the constructor, so this is only done once.
I’ve profiled the same run after applying those changes and
minimatchis no longer the bottleneck, insteadglobSync()is the next bottleneck