Conversation
resist/shocal-dashboard.js
Outdated
| methods: { | ||
| fetchLatest() { | ||
| fetch( | ||
| "https://www.shocal.org/developers/apis/peepl/v1/data?apikey=Xau08wz65Sd12BaX5lU6B1W0lHyMD52167q5i" |
Contributor
There was a problem hiding this comment.
@zarino I'm not sure that this should be published in the public repo. Any ideas how we can store it more securely? And I will get Max to cycle the key.
Contributor
Author
There was a problem hiding this comment.
Oh no! I figured it was ok, as you committed it here on 2nd Feb.
I guess ideally we should store this in either a WordPress option (yuck) or in an environment variable on the server.
Might not be worth doing either, though, if you’d rather just get this all set up in a self-contained mini site anyway.
I was getting errors without this, for some reason.
This made _some_ sense in the old Peepl theme, but has just been getting in the way in the new Resist theme so far.
Can now deploy to both staging and production (staging by default), and supports -h / --help for showing help.
Also, more weights of Work Sans, which was a change we made ages ago but forgot to commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.