Merged
Conversation
- パスワードに利用するFakerのカテゴリーを増やした - 単語の一部の文字を大文字に変換した - 数値が末尾だけでなく、ランダムな位置に配置されるようにした
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Passfaker generator by expanding word sources, introducing random uppercase transformations, and allowing numbers to appear at arbitrary positions.
- Added new Faker categories for password components
- Implemented
random_char_upcaseto uppercase one character per word - Changed number insertion and ordering, and bumped version to 0.2.0
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/passfaker_spec.rb | Updated the regex to detect digits anywhere in the password |
| lib/passfaker/version.rb | Bumped VERSION from 0.1.0 to 0.2.0 |
| lib/passfaker/generator.rb | Added new Faker categories, removed internal dashes, uppercased a random char, shuffled words & numbers |
Comments suppressed due to low confidence (1)
lib/passfaker/generator.rb:32
- The new
random_char_upcasemethod introduces behavior that isn’t currently exercised by any spec. Consider adding a test to verify that exactly one character is randomly converted to uppercase.
def self.random_char_upcase(word)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ジェネレーターを改修。