Move checkIsRunning after tryElevate to ensure that we have permission to create GLOBAL event#149
Open
stephen9358 wants to merge 1 commit intojagt:masterfrom
Open
Move checkIsRunning after tryElevate to ensure that we have permission to create GLOBAL event#149stephen9358 wants to merge 1 commit intojagt:masterfrom
stephen9358 wants to merge 1 commit intojagt:masterfrom
Conversation
…n to create GLOBAL event
Owner
|
Hi! What's this PR is fixing? Is that elevate would fail in some cases? |
Author
Creating global event will fail without elevating first, so we see a MessageBox saying that already running, which it's not an accurate error message.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the mismatched error message when running with non-admin context.