Changing old var to let (No declaration issues)#70
Open
Ramen900 wants to merge 2 commits intojakesgordon:masterfrom
Open
Changing old var to let (No declaration issues)#70Ramen900 wants to merge 2 commits intojakesgordon:masterfrom
Ramen900 wants to merge 2 commits intojakesgordon:masterfrom
Conversation
Ramen900
changed the title
|
you should have added more image examples, but this is still very valid of a change. your verification process seems to be sound, but it might still be wise to do further playtesting to ensure that no bugs went through the first playtest. I am just a student that is reviewing a fellow peer's PR for an assignment. |
Author
Not Following Assignment Instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: This PR changes changes this project by changing var to let created best practice coding for this fun Tetris game allowing better memory management.
Where: In the index.html that hosts the game UI, had changed the var tables to let tables
Why: This matters because it removes function-scoped systems and is now block-scoped, let also prevents redeclaration and throws a syntax error when multiple declarations are declared, if a var is declared later after it is used it makes the variable return an undefined value. Asynchronous functions are now possible because multiple instances are created with let, block scopes are now easier to use in this project for future updates.
Verified: I verified this by playtesting the game. I expected the game to run smoothly. I observed the game running as intended no TDZ errors and smooth gameplay. Here are some screenshots:
Status: This PR is ready for review.