Open
Conversation
Owner
|
Can you explain what this is good for? |
Author
|
It compiles and creates a docker image for the proxy by using github action automation |
Owner
|
Yes, that is obvious from the changes. Can youplease explain what you would use this for? How would you even use the docker image? |
Author
|
Sure. I'm using it for a testcase where I simulate a bad internet connection. I use testcontainers.org to run the stuff I need for my integration tests, so I built the container. I created the PR because I tought it could be useful for anyone else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I cherry-picked the fix from d9k and added a Dockerfile + GH action.