Skip to content

Conversation

@kevinwheeler
Copy link

As per @andrewburgess 's comment on issue #93, it is important that auth route pattern is not a prefix of the callback route pattern.

As per @andrewburgess 's comment on issue jaredhanson#93, it is important that auth route pattern is not a prefix of the callback route pattern.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 985ed65 on kevinwheeler:patch-1 into 2b74dd0 on jaredhanson:master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 16, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 985ed65 on kevinwheeler:patch-1 into 2b74dd0 on jaredhanson:master.

@rkt2spc
Copy link

rkt2spc commented Apr 10, 2017

@kevinwheeler
Which version of express are you using? Pattern prefix shouldn't be a problem for express router

@jony89
Copy link

jony89 commented Jan 12, 2018

@rocketspacer, I think this can be closed since @andrewburgess was using regex for his routes, so obviously there is the prefix issue, it is irrelevant to passport-facebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants